ZOOKEEPER-4734: FuzzySnapshotRelatedTest becomes flaky when transient disk failure appears #2053
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disk failure appears
asfgit
force-pushed
the
branch-3.9
branch
2 times, most recently
from
078a3e6
to
2360323
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ZOOKEEPER-4734 for details on the symptom and diagnostic.
The fix of ZOOKEEPER-4734 is implemented. In my local machine, it is able to pass all test cases.
I add some configurable retry mechanism to ZkDataBase#loadDataBase() to tolerate possible transient disk failure.
Any comments and suggestions would be appreciated.